Skip to content

reduce log level of a few low-value logs - #752

Merged
davidzhao merged 4 commits into
mainfrom
dz/dtmf-debug-log
Jul 31, 2026
Merged

reduce log level of a few low-value logs#752
davidzhao merged 4 commits into
mainfrom
dz/dtmf-debug-log

Conversation

@davidzhao

Copy link
Copy Markdown
Member

No description provided.

@davidzhao
davidzhao requested a review from a team as a code owner July 22, 2026 23:21

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Comment thread pkg/sip/media_port.go Outdated
@davidzhao
davidzhao merged commit d5dd982 into main Jul 31, 2026
5 of 6 checks passed
@davidzhao
davidzhao deleted the dz/dtmf-debug-log branch July 31, 2026 07:31
Comment thread pkg/sip/media_port.go
p.stats.Streams.Add(1)
p.mediaReceived.Break()
log := p.log.WithValues("ssrc", ssrc)
log.Infow("accepting RTP stream")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one helped us find both these issues out, but once we handle the second one as well this can be a number, no need to log every time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants